Do not suppress work titles with source on translations #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rules rely on NormalizeWorkTitles doing its juggling in the background, and cover a bit more than what is currently done by that post-processing. (Eventually we might come to remove this "source on title blocks bib 240" altogether.)
klngwll
requested changes
Nov 14, 2023
The specs run before all post-processing; so the 130/240 juggling isn't part of the equation. This is a bit obscure, as any advanced post-processing cannot be reflected in the specs (in theory throughout all of marcframe, not just for these two fields). Not sure what kind of comment is needed (there are many specs in 240 which aren't "real" anymore due to the title "juggling"); this PR already adds: "IMPORTANT": "Actual results are subsequently modified by the NormalizeWorkTitles postProcessing step!",which may be enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules rely on NormalizeWorkTitles doing its juggling in the background, and cover a bit more than what is currently done by that post-processing.
(Eventually we might come to remove this "source on title blocks bib 240" altogether.)