Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include sameAs URIs when loading instance relators #1336

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Include sameAs URIs when loading instance relators #1336

merged 1 commit into from
Nov 21, 2023

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Nov 20, 2023

...because that's the given URI form in the batch import.

@kwahlin kwahlin changed the title Include sameAs URI's when loading instance relators Include sameAs URIs when loading instance relators Nov 20, 2023
klngwll
klngwll approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@klngwll klngwll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niklasl
niklasl approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right; the linkfinder matches on the sameAs! LGTM!

@kwahlin kwahlin merged commit 8288909 into develop Nov 21, 2023
1 check passed
@kwahlin kwahlin deleted the bugfix/lxl-4266-roles-not-moved-in-batch-import branch November 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klngwll klngwll klngwll approved these changes

@niklasl niklasl niklasl approved these changes

@olovy olovy Awaiting requested review from olovy

@katnai1 katnai1 Awaiting requested review from katnai1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwahlin @niklasl @klngwll