Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/trailing period in work title #1338

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Bugfix/trailing period in work title #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c5c376
Don't append period to work title if no parts to be added after
kwahlin Nov 21, 2023
824c7ed
Remove superfluous code
kwahlin Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions librisworks/src/main/groovy/se/kb/libris/mergeworks/Util.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,9 @@ class Util {
]

static void appendTitlePartsToMainTitle(Map title, String partNumber, String partName = null) {
if (title['mainTitle'][-1] != '.') {
title['mainTitle'] += '.'
}
if (partNumber && partName) {
title['mainTitle'] += " $partNumber, $partName"
} else if (partNumber) {
title['mainTitle'] += " $partNumber"
} else if (partName) {
title['mainTitle'] += " $partName"
def part = [partNumber, partName].grep().join(', ')
if (part) {
title['mainTitle'] += "${title['mainTitle'][-1] == '.' ? '' : '.'} $part"
}
}

Expand Down