Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bulk merge #1509

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Feature/bulk merge #1509

merged 8 commits into from
Nov 7, 2024

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Nov 4, 2024

I think we can merge this now. Should be fairly easy to just replace the part where we emulate the changes (

) with the results of a dry-run once we have that in place.

TODO:

  • Address this:
    // TODO: What if there are links to a record uri?

    I don't think we should replace links to record uris with links to thing uri so the question is what to do with them (if they ever appear)?
  • Would be nice to make the frontend preview aware of and able to display different types of changes depending on the change sets content.

@kwahlin kwahlin marked this pull request as draft November 4, 2024 16:09
@kwahlin kwahlin requested a review from olovy November 4, 2024 16:11
@kwahlin kwahlin marked this pull request as ready for review November 7, 2024 11:02
Copy link
Contributor

@olovy olovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there is now a bit of unclear division of responsibility between the different Specification classes and the corresponding whelktool scripts. But that will hopefully be fixed when we use recorded dry-runs for previews.

@olovy olovy merged commit c2e2718 into develop Nov 7, 2024
1 check passed
@olovy olovy deleted the feature/bulk-merge branch November 7, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants