Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bulk merge uris as strings #1515

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Feature/bulk merge uris as strings #1515

merged 3 commits into from
Nov 12, 2024

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Nov 12, 2024

See also libris/lxlviewer@d639831 and libris/definitions@da11d03

Let's go with this for now? Instead of #1514.

@kwahlin kwahlin requested review from olovy and lrosenstrom November 12, 2024 14:25
olovy
olovy approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@olovy olovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kwahlin kwahlin merged commit 89c697a into develop Nov 12, 2024
1 check passed
@kwahlin kwahlin deleted the feature/bulk-merge-uris-as-strings branch November 12, 2024 16:09
kwahlin added a commit that referenced this pull request Nov 14, 2024
@kwahlin
Revert "Merge pull request #1515 from libris/feature/bulk-merge-uris-…
975cafe 
…as-strings"

This reverts commit 89c697a, reversing
changes made to 49b735d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olovy olovy olovy approved these changes

@lrosenstrom lrosenstrom Awaiting requested review from lrosenstrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwahlin @olovy