Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MatchForm (reduce complexity) #1527

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Nov 21, 2024

Couldn't resist cleaning up some more. Not necessary to include in the release.

@kwahlin kwahlin requested a review from olovy November 21, 2024 10:17
Copy link
Contributor

@olovy olovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Would be nice to refactor the tests so that MatchForm can use JsonLd::subTypes directly

@kwahlin kwahlin merged commit f001a0d into develop Nov 22, 2024
1 check passed
@olovy olovy deleted the feature/refactor-MatchForm branch November 22, 2024 16:06
kwahlin added a commit that referenced this pull request Nov 25, 2024
Refactor MatchForm (reduce complexity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants