Bugfix/lxl 4600 unverified ids #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olovy
approved these changes
Dec 10, 2024
olovy
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Filter out surely invalid ids when collecting short ids * Load only verified xl ids in collectFormBNodeIdToResourceIds * Don't add prefix to already prefixed types * Add missing type declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more defensive approach when loading ids from list. Solves
org.apache.jena.query.QueryParseExceptionwhen running e.g. https://libris-qa.kb.se/katalogisering/directory-care/bulkchanges/2m87134b00vqxm3k where the given link (https://github.com/katnai1/MAV/blob/main/test_radera_Kalmar1.txt) does not point to the actual file (https://raw.githubusercontent.com/katnai1/MAV/refs/heads/main/test_radera_Kalmar1.txt) and thus lots of lines of html were loaded as "ids" and consequently also embedded in the Sparql query for the selection.Note: The last two commits are unrelated to the above. Just minor flaws that I stumbled over when testing the original fix.