Bugfix/delete referenced by bulk job #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olovy
reviewed
Dec 11, 2024
| @@ -2773,8 +2773,7 @@ class PostgreSQLComponent { | |||
| def allow = JsonLd.ALLOW_LINK_TO_DELETED + (jsonld?.cascadingDeleteRelations() ?: Collections.EMPTY_SET) | |||
| def referencedBy = followDependers(identifier, allow) | |||
There was a problem hiding this comment.
Note to selves: the actual problem is that we are using followDependers though we only care about docs linking directly to the doc being deleted? But there are only links when we block the delete so probably fine.
Changed in 230fe6f
olovy
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://libris.kb.se/katalogisering/8tgnxg2q6d26k657 failed due to the term to deprecate (https://id.kb.se/term/barn/%C3%85lderdomshem) being referenced in another
bulk:Jobwhich prevented the term from being deleted. We should not exclude all links inbulk:Jobfrom relinking but rather exclude links inbulk:depŕecatespecifically.Also fixed the error message which I think was very confusing, see https://libris.kb.se/_bulk-change/reports/8tgnxg2q6d26k657-2024-12-11T133742/ERRORS.txt. Only
k4rz49t1h5nfxls5 at bulk:changeSpec.bulk:matchForm.instanceOf.subjectis of interest, the rest are just records linking to k4rz49t1h5nfxls5 (directly or indirectly). This information is already available via "Används i" in the cat client anyway.