Add profile negotiation for EMM dump data. #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannistsiroyannis
requested review from
niklasl,
andersju,
kaipoykio,
lrosenstrom,
olovy and
kwahlin
olovy
reviewed
Dec 13, 2024
| @@ -357,15 +359,29 @@ private static void writeJsonLdLine(Object object, OutputStream os) throws IOExc | |||
| os.write("\n".getBytes(StandardCharsets.UTF_8)); | |||
| } | |||
|
|
|||
| private static Object wrapDoc(Document doc, Document contextDoc) { | |||
| private static Object formatDoc(Document doc, Document contextDoc, Whelk whelk, TargetVocabMapper targetVocabMapper, String profile) { | |||
| var context = new ArrayList<>(); | |||
| context.add(null); | |||
| context.add(contextDoc.getRecordIdentifiers().getFirst()); | |||
There was a problem hiding this comment.
I believe that when a profile is selected we should point to that context here.
Same with the first document of the dump. It should be the profile context instead of the system context.
See e.g. @context
https://libris-qa.kb.se/fxql7jqr38b1dkf/data.jsonld?profile=https%3A%2F%2Fid.kb.se%2Fsys%2Fcontext%2Ftarget%2Fsdo-w3c&embellished=false
There was a problem hiding this comment.
Very good comments! I believe I've addressed the problems now. Take another look, if I got the context-stuff right?
…ct context for profiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds profile negotiation for EMM, the same way it exists for normal record GETs in libris (using &profile=..profile url..).