Fix front panel touch on Vita #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsn8887
changed the title
|
@Wohlstand, can you review? |
|
I already did a quick look on this, and this looks fine for me, but I probably should try to build a local thing and verify how it works on my Vita in action. |
|
Nice catch. Somehow this (0 touch id) was fixed properly for sdl3, but not sdl2. |
|
I think you are right this should be targeting SDL2 branch but also be put in the release branch for next release. |
rsn8887
force-pushed
the
fix_vita_touch
branch
from
3afe2f2
to
ef7639c
Compare
|
Ok I changed it to target SDL2 branch. It should be ready. |
|
@slouken lgtm |
|
Merged, thanks! |
|
This is in for the next SDL2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vita touch code was ignoring front panel touch events, because they were sent internally using Touch_ID 0, but it should have been TOUCH_ID 1. This commit re-enables front panel touch events.
Fixes issue #11441
Tested with latest ScummVM compiled from master.