GPU: Enable Metal validation in debug mode #11691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpydog
force-pushed
the
metal-validation
branch
from
1d8b1bf to
169ad5a
Compare
MirkoCovizzi
approved these changes
Dec 23, 2024
flibitijibibo
approved these changes
Dec 23, 2024
slouken
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a GPU device in debug mode, we should enable Metal validation like we do for Vulkan and D3D12. This native validation helps catch errors that are difficult or impossible to detect from SDL's side (like malformed shaders). Unlike other APIs, Metal's validation layers are enabled via an environment variable that must be set before device creation.