-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add basic Ubuntu Touch functions #12543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Semphriss
wants to merge
1
commit into
libsdl-org:main
Choose a base branch
from
Semphriss:ubuntu-touch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Ubuntu Touch / Lomiri | ||
|
||
Ubuntu Touch being similar to Ubuntu desktop, most features should be supported | ||
out-of-the-box with SDL. | ||
|
||
## Developing apps | ||
|
||
Ubuntu Touch apps are developed using [Clickable](https://clickable-ut.dev/). | ||
|
||
Clickable provides an SDL template. It is highly recommended to use the template | ||
as a starting point for both new and existing apps. | ||
|
||
## Considerations | ||
|
||
Ubuntu Touch is similar to the desktop version of Ubuntu, but presents some | ||
differences in behavior. Developers should be wary of the following: | ||
|
||
### SDL_GetPrefPath | ||
|
||
The only allowed writable folder is `~/.local/share/<appname>/`, where | ||
`<appname>` is the identifier string for the app. It can be found in the | ||
`manifest.json` file under the key `"name"`, and usually looks like | ||
`appname.yourname`. | ||
|
||
A future version of SDL may change how `SDL_GetPrefPath` operates on Ubuntu | ||
Touch to make it ignore its arguments and always choose the correct writable | ||
folder. For future-proof-ness, using `SDL_GetPrefPath("", "<appname>")` as a | ||
writable directory is a safe choice. | ||
|
||
### Video driver | ||
|
||
Currently, [a bug](https://github.com/libsdl-org/SDL/issues/12247) forces SDL to | ||
use the Wayland driver on Ubuntu Touch. No changes are needed in apps. | ||
|
||
### Extra functions | ||
|
||
SDL provides `SDL_IsUbuntuTouch()` to differentiate between Ubuntu Touch and | ||
regular Unix, which can help if certain platform-specific tweaks are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
Simple DirectMedia Layer | ||
Copyright (C) 1997-2025 Sam Lantinga <[email protected]> | ||
|
||
This software is provided 'as-is', without any express or implied | ||
warranty. In no event will the authors be held liable for any damages | ||
arising from the use of this software. | ||
|
||
Permission is granted to anyone to use this software for any purpose, | ||
including commercial applications, and to alter it and redistribute it | ||
freely, subject to the following restrictions: | ||
|
||
1. The origin of this software must not be misrepresented; you must not | ||
claim that you wrote the original software. If you use this software | ||
in a product, an acknowledgment in the product documentation would be | ||
appreciated but is not required. | ||
2. Altered source versions must be plainly marked as such, and must not be | ||
misrepresented as being the original software. | ||
3. This notice may not be removed or altered from any source distribution. | ||
*/ | ||
#include "SDL_internal.h" | ||
|
||
#ifdef SDL_PLATFORM_LINUX | ||
#include <stdio.h> | ||
#include <unistd.h> | ||
|
||
bool SDL_IsUbuntuTouch(void) | ||
{ | ||
return access("/etc/ubuntu-touch-session.d/", F_OK) == 0; | ||
} | ||
|
||
#endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what conditions does the application need to know this is Ubuntu Touch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used internally by SDL to detect when to use certain tweaks for Ubuntu Touch, like the Wayland driver bug. Since Ubuntu Touch is just Linux, it doesn't expose any compiler macro like
__UBUNTU_TOUCH__
that could help determine when to use these tweaks.Since app developers may also want to tweak their apps on Ubuntu Touch, I considered it might help to expose that function in the API.