Skip to content

Use motor sequence ID 0 in the HIDAPI GIP driver #12940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented May 2, 2025

Using a 0 sequence number is always allowed and avoids having to synchronize sequence numbers with the controller (and potentially confusing other things talking to the controller)

Also fixes occasional long running rumble at controller connection.

@slouken
Copy link
Collaborator Author

slouken commented May 2, 2025

@endrift, can you review?

Copy link
Contributor

@endrift endrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will send a sequence number of 0 for the system command 9 too, which is not correct.

Also wow I didn't realize how much trailing whitespace I'd accidentally left in. Thanks for fixing that.

Using a 0 sequence number is always allowed and avoids having to synchronize sequence numbers with the controller (and potentially confusing other things talking to the controller)

Also fixes occasional long running rumble at controller connection.
@slouken slouken merged commit f8c7790 into libsdl-org:main May 5, 2025
39 checks passed
@slouken slouken deleted the gip branch May 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants