add possibility to use different hash algorithms in RSAES-OAEP #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi I made the following changed to perl's CryptX module which should be fine but I get: realloc(): invalid next size |
|
Ping @karel-m |
sjaeckel
force-pushed
the
rsaaes_oaep_hashes
branch
from
067c5e2 to
77a3fcb
Compare
ah, I made a mistake, can you please try again? |
|
Yes, that was able to decrypt my test |
|
Just need the encrypt now and I can test that too :-) |
sjaeckel
force-pushed
the
rsaaes_oaep_hashes
branch
from
77a3fcb to
fa543c1
Compare
Can you give it a try? |
sjaeckel
force-pushed
the
rsaaes_oaep_hashes
branch
from
fa543c1 to
22ee920
Compare
sjaeckel
changed the title
|
These changes seem to work fine for me. I tested with the following combinations encrypting with a modified Perl Crypt::PK::RSA and decrypting the keys with xmlsec1 (using openssl library) The data method is just the key used to encrypt the data in my XML files |
timlegge
added a commit
to timlegge/perl-CryptX
that referenced
this pull request
Mar 12, 2023
Requires changes from libtom libtom/libtomcrypt#612
timlegge
added a commit
to timlegge/perl-CryptX
that referenced
this pull request
Mar 12, 2023
Requires changes from libtom libtom/libtomcrypt#612
timlegge
added a commit
to timlegge/perl-CryptX
that referenced
this pull request
Mar 12, 2023
Requires changes from libtom libtom/libtomcrypt#612
timlegge
added a commit
to timlegge/perl-CryptX
that referenced
this pull request
Mar 18, 2023
Requires changes from libtom libtom/libtomcrypt#612
|
@sjaeckel any update/progress? |
sjaeckel
force-pushed
the
rsaaes_oaep_hashes
branch
from
22ee920 to
8b6d39e
Compare
|
Thanks for keeping it fresh :-).
I was going to suggest a separate API call _ex to take a page out of
openSSL's book and you probably don't want to take a page out of openSSL's
book...
But, it's already _ex... :-)
Tim
Timothy Legge
***@***.***
***@***.***
…On Mon, Aug 7, 2023 at 10:49 AM Steffen Jaeckel ***@***.***> wrote:
@sjaeckel <https://github.com/sjaeckel> any update/progress?
not really ... at least I've rebased on current develop.
@karel-m <https://github.com/karel-m> any comments or suggestions how we
could handle the API break a bit better?
—
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH3N665KPUONKXNQDJ3S6DXUDW43ANCNFSM6AAAAAAVXQ44KA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
timlegge
added a commit
to timlegge/perl-CryptX
that referenced
this pull request
Aug 9, 2023
Requires changes from libtom libtom/libtomcrypt#612
|
@karel-m could you please have a look at this PR as well? |
|
1/ I do not like the variable name 2/ We are breaking compatibility of Otherwise looks good. |
|
@sjaeckel could you please rebase |
karel-m
pushed a commit
to DCIT/perl-CryptX
that referenced
this pull request
Oct 9, 2023
Requires changes from libtom libtom/libtomcrypt#612
The hash algorithms used in the MGF and to create the hash of the Label must not forcibly be the same. This change allows to use different algorithms. Unfortunately this breaks the API if you use one of: * `rsa_decrypt_key_ex()` * `rsa_encrypt_key_ex()` * `pkcs_1_oaep_decode()` * `pkcs_1_oaep_encode()` The `rsa_decrypt_key()` and `rsa_encrypt_key()` macros are still the same. Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
rsaaes_oaep_hashes
branch
from
8b6d39e to
63091c9
Compare
and |
karel-m
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash algorithms used in the MGF and to create the hash of the Label must not forcibly be the same. This change allows to use different algorithms.
Unfortunately this breaks API if you use
rsa_decrypt_key_ex(). Thersa_decrypt_key()macro is still the same.Checklist