Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #678

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Some improvements #678

merged 6 commits into from
Dec 11, 2024

Conversation

sjaeckel
Copy link
Member

Some more improvements on top of #677

@gregoa could you please check if this fixes the x32 build I've seen happening on Debian?

@sjaeckel sjaeckel force-pushed the some-improvements branch 2 times, most recently from ae6713e to 661fd96 Compare December 10, 2024 20:33
@sjaeckel sjaeckel requested a review from levitte December 10, 2024 20:52
@levitte
Copy link
Collaborator

levitte commented Dec 11, 2024

I added a fixup patch to give the compiler a chance to warn if err_2_str gets over-filled.

@sjaeckel, you know how to handle such commits, yeah? git rebase -i --autosquash?

* `CONSTPTR()` must be 32bit.
* `CRYPT_HASH_OVERFLOW` test operates on `unsigned long`, which is only
  32bit wide on x32.

Signed-off-by: Steffen Jaeckel <[email protected]>
* Add at least a `-h` option, sometimes more.
* Fix the exit codes of some of them.
* Make them all compile with `LTC_EASY`.

Signed-off-by: Steffen Jaeckel <[email protected]>
... at least at compile time.

Signed-off-by: Steffen Jaeckel <[email protected]>
There are cases where we want to use an MPI provider, but the package is
not installed in the system, so `pkg-config` can't find it.
To solve this simply ignore the errors created and only print something
if the user asks us to by passing `V=1`.

Signed-off-by: Steffen Jaeckel <[email protected]>
Fixes 2400883

Signed-off-by: Steffen Jaeckel <[email protected]>
@sjaeckel
Copy link
Member Author

I added a fixup patch to give the compiler a chance to warn if err_2_str gets over-filled.

@sjaeckel, you know how to handle such commits, yeah? git rebase -i --autosquash?

Thanks!

I've added one more patch with what resulted in the build failures of the previous PR, + one more clean-up patch.

Copy link
Collaborator

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw what you did. Looks fine by me

@sjaeckel sjaeckel merged commit a81dab9 into develop Dec 11, 2024
75 checks passed
@sjaeckel sjaeckel deleted the some-improvements branch December 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants