Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github actions for installing Lua/Luarocks, check all Lua versions #67

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

rolandlo
Copy link
Collaborator

Addresses #66 (comment)

The tests don't succeed with Lua 5.1 and Lua 5.2 yet, but maybe there is a simple fix.

@rolandlo rolandlo mentioned this pull request Mar 18, 2024
@RiskoZoSlovenska
Copy link
Contributor

The 5.1 failure occurs due to luaffi-tkl's use of luaL_tolstring (which is undefined in Lua 5.1) and needs to be fixed upstream.
The 5.2 failure occurs due to luaffi-tkl's use of bitwise operators (which were added to Lua in 5.3) in its bit.lua and also needs to be fixed upstream.

@RiskoZoSlovenska
Copy link
Contributor

BTW, while we're at it, it might be good to also bump the busted and luacheck versions in the Makefile.

@rolandlo
Copy link
Collaborator Author

The 5.1 failure occurs due to luaffi-tkl's use of luaL_tolstring (which is undefined in Lua 5.1) and needs to be fixed upstream.

I agree. Seems like luaL_tostring can simply be replaced by lua_tostring.

The 5.2 failure occurs due to luaffi-tkl's use of bitwise operators (which were added to Lua in 5.3) in its bit.lua and also needs to be fixed upstream.

Here I think we can simply install luabitop for versions 5.1 and 5.2. It removes <prefix>/share/lua/5.2/bit.lua and replaces it by <prefix>/lib/lua/5.2/bit.so

@rolandlo
Copy link
Collaborator Author

Here I think we can simply install luabitop for versions 5.1 and 5.2. It removes <prefix>/share/lua/5.2/bit.lua and replaces it by <prefix>/lib/lua/5.2/bit.so

That works so locally, but not in the CI pipeline. I have reported the two issues upstream and they will be addressed. It just takes some time.

@rolandlo rolandlo merged commit e0bdc2d into libvips:master Mar 19, 2024
4 checks passed
@rolandlo rolandlo deleted the improve-ci branch March 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants