Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure variadic call is null-terminated #407

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

kleisauke
Copy link
Member

@kleisauke
Copy link
Member Author

I'm not sure who maintains ruby-vips in Debian, it's still on v2.1.4.

@gcsideal FYI: backporting this PR should help migrate libvips to 8.16.0 in Debian.

@jcupitt jcupitt merged commit b773f31 into libvips:master Nov 4, 2024
11 checks passed
@jcupitt
Copy link
Member

jcupitt commented Nov 4, 2024

Ooop, bad oversight. Well done for finding this!

@kleisauke kleisauke deleted the 8.16-add_alpha-compat branch November 4, 2024 12:35
@gcsideal
Copy link

gcsideal commented Nov 4, 2024

I'm not sure who maintains ruby-vips in Debian, it's still on v2.1.4.

The tracker page of ruby-vips contain the information: Jongmin Kim and Utkarsh Gupta.
No, libvips 8.6.0 will not migrate even with this fix. It has a build time testing regression on s390x, sparc64 and hppa at least. It seems the 'testing sample.jpg pfm ... save / load difference' is too big. Need further checking.

@kleisauke
Copy link
Member Author

kleisauke commented Nov 4, 2024

Thanks for the information! PR libvips/libvips#4242 should fix these test failures on big-endian systems.

@gcsideal
Copy link

gcsideal commented Nov 4, 2024

Thanks for the information! PR libvips/libvips#4242 should fix these test failures on little-endian systems.

Can be, but unfortunately the mentioned architectures are big-endian ones. Do you have a fix for these as well?

@kleisauke
Copy link
Member Author

Apologies, I meant big-endian machines. I was confused due to the changelog note added in commit libvips/libvips@f06db0f.

@kleisauke
Copy link
Member Author

ChangeLog note will be fixed via PR libvips/libvips#4246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants