Tick() can handle checkboxes that have no value #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Thanks @jmadler and @simbabque! Wow, pull request #1. That was well before my time. So nice to see these little bits of history making it into the codebase.
| @@ -4,9 +4,12 @@ | |||
|
|
|||
| <input type="checkbox" name="foo" value="hello" /> Hello<br /> | |||
| <input type="checkbox" name="foo" value="bye" /> Bye<br /> | |||
| <input type="checkbox" name="foo" value="arse" /> Arse<br /> | |||
| <input type="checkbox" name="foo" value="parse" /> Parse<br /> | |||
There was a problem hiding this comment.
Not a change I would have made, but I'll approve 😆
|
I don't think I had even heard of github in 2011. I was still hacking away using CGI and SVN. |
jmadler
approved these changes
Jul 4, 2022
| @@ -4,9 +4,12 @@ | |||
|
|
|||
| <input type="checkbox" name="foo" value="hello" /> Hello<br /> | |||
| <input type="checkbox" name="foo" value="bye" /> Bye<br /> | |||
| <input type="checkbox" name="foo" value="arse" /> Arse<br /> | |||
| <input type="checkbox" name="foo" value="parse" /> Parse<br /> | |||
There was a problem hiding this comment.
Not a change I would have made, but I'll approve 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased the work done by @jmadler in #1 and added tests.
Closes #1.
Fixes #192.