Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unsigned long long cast operator #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Dec 30, 2019

helps fix
FSize_test.cc:180:25: error: implicit conversion from 'long long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]

Signed-off-by: Khem Raj [email protected]

helps fix
FSize_test.cc:180:25: error: implicit conversion from 'long long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]

Signed-off-by: Khem Raj <[email protected]>
@mvidner
Copy link
Member

mvidner commented Jan 10, 2020

Thanks, Raj!

But, as you can see, the tests in Travis have failed: https://travis-ci.org/libyui/libyui/builds/631109838
(Unfortunately the exact reason cannot be seen. We should fix the build script to pass the verbose flag: make test ARGS=-V)

Also, I don't experience the error this is supposed to fix. What is your build environment? (Which distribution and compiler, with versions, build flags...)

@kraj
Copy link
Contributor Author

kraj commented Jan 10, 2020

Thanks, Raj!

But, as you can see, the tests in Travis have failed: https://travis-ci.org/libyui/libyui/builds/631109838
(Unfortunately the exact reason cannot be seen. We should fix the build script to pass the verbose flag: make test ARGS=-V)

Also, I don't experience the error this is supposed to fix. What is your build environment? (Which distribution and compiler, with versions, build flags...)

this is going to hit when gcc10 ( currrently trunk) will release. Yeah I saw the error and I kind
of did not pursue it after that. Perhaps there is another way to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants