Use a trivial engine for tests #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a hobbled stockfish engine for game tests, use a trivial engine that just picks the first legal move on a board. This should avoid the random timeouts in tests when games go on too long due to the hobbled test engine still making reasonable moves.
|
I'm not actually sure if this will solve the timeout problem since it happens so seldomly. But the only thing I can think of that would lead to a timeout error is the test game going too long. The various engines are cached, so there's no time taken to download them. |
AttackingOrDefending
approved these changes
Jan 4, 2025
|
I think it's worth the try if this will solve the random timeouts. |
AttackingOrDefending
merged commit 9f82d28
into
lichess-bot-devs:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Instead of a hobbled stockfish engine for game tests, use a trivial engine that just picks the first legal move on a board. This should avoid the random timeouts in tests when games go on too long due to the hobbled test engine still making reasonable moves. Plus, it should cut down the amount of logging done during tests.
Related Issues:
N/A
Checklist:
Screenshots/logs (if applicable):
N/A