Handle None values in pgn_queue #1095
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, probably when a lichess-bot session is ended with Ctrl-C, the function that handles the pgn_queue will receive a None value. This causes an error and prevents PGN files from being written. This change ignores None values when they arrive from the queue.
AttackingOrDefending
approved these changes
Mar 16, 2025
AttackingOrDefending
merged commit d08fcd7
into
lichess-bot-devs:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Sometimes, probably when a lichess-bot session is ended with Ctrl-C, the function that handles the pgn_queue will receive a None value. This causes an error and prevents PGN files from being written.
This change ignores None values when they arrive from the queue.
Related Issues:
Checklist:
Screenshots/logs (if applicable):