implement api/player/autocomplete #48
Conversation
handsamtw
changed the title
handsamtw
changed the title
|
Work on #6 |
handsamtw
changed the title
There was a problem hiding this comment.
Hey, thank you very much for the PR! I’ve left a few comments quickly, these just be seen as instructive feedback. Since it’s late I may be terse in my wordings so please ask if something is unclear to you.
If you do not have the time to fix those, I’ll eventually pick it up. Cheers
|
Hello @kraktus , I have made all necessary changes to resolve the comment you left previously.
|
…characters All client-code for Lichess already check that and lichobile does too: https://github.com/lichess-org/lichobile/blob/663e69fab10e4267a9b3369febe85d1363816ba2/src/ui/players/PlayersCtrl.ts#L51 prompted by lichess-org/berserk#48. Note that currently it does sometimes return a result (undocumented), hitting the `userIdsLikeCache` cache, so maybe this is intended.
…characters All client-code for Lichess already check that and lichobile does too: https://github.com/lichess-org/lichobile/blob/663e69fab10e4267a9b3369febe85d1363816ba2/src/ui/players/PlayersCtrl.ts#L51 prompted by lichess-org/berserk#48. Note that currently it does sometimes return a result (undocumented), hitting the `userIdsLikeCache` cache, so maybe this is intended.
|
Hello @kraktus , are we good to merge and closed this pr? |
|
Hey, thanks for the good work, I'd still like to get a test to ensure the lightuser type is correct, and add the follower parameter (can take it from #53) I'll finish in a few days when I'm more available. |
… `only_followed_players` parameter `object` was shadowing `object`. TODO: test
|
Thanks! Implementing a test allowed to find several issues: e6cc202 |
Implementing api/player/autocomplete api.
I got one questions regarding the param "friend", the name and definition of this parameter is unclear to me.
Thus, I didn't add it to the implementation at this moment. Hope that somebody could explain to me.
The Documentation link: https://lichess.org/api#tag/Users/operation/apiPlayerAutocomplete