Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /swiss/{id}.trf endpoint #63

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

Anupya
Copy link
Contributor

@Anupya Anupya commented Nov 3, 2023

Description

  • Implement /swiss/{id}.trf
    • I am not sure how to define a return type TRF (as it is not JSON formattable), so the endpoint's return type will be str.
    • This is the reason I did not include a test as the API endpoint does not return JSON.

After merge

Check off /swiss/{id}.trf in #6.

Checklist

Checklist when adding a new endpoint
  • Added new endpoint to the README.md
  • Ensure that my endpoint name does not repeat the name of the client. Wrong: client.users.get_user(), Correct: client.users.get()
  • Typed the returned JSON using TypedDicts in berserk/types/, example <--not returning JSON so not relevant
  • Tested GET endpoints not requiring authentification. Documentation, example <--not returning JSON so not relevant
  • Added the endpoint and your name to CHANGELOG.md in the To be released section (to be created if necessary) <--leaving it up to the maintainer

@Anupya Anupya marked this pull request as ready for review November 3, 2023 20:05
@kraktus kraktus force-pushed the Anupya/add-swiss-trf-endpoint branch from 64aad76 to c11c1d1 Compare November 3, 2023 20:14
@kraktus kraktus merged commit d735333 into lichess-org:master Nov 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants