-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added /api/bot/online API #8
added /api/bot/online API #8
Conversation
Co-authored-by: icp <[email protected]>
Thanks, @icp1994, for your suggestions. I incorporated them all in the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good. There's just one line I forgot to remove in yesterday's review. After you are done, please squash/fixup your commits into one. The msg should be something like: "Add /api/bot/online endpoint"
Co-authored-by: icp <[email protected]>
Done @icp1994 |
Thanks! Release as v0.12.1 |
Added REST endpoint for /api/bot/online.
This is to implement the first task in the issue #6.
This is my first PR for this project. If this PR is ok, I plan to implement all the tasks under this issue.
All tests are getting passed when run locally.