Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /api/bot/online API #8

Merged
merged 5 commits into from
May 13, 2023

Conversation

kalpgarg
Copy link
Contributor

Added REST endpoint for /api/bot/online.

This is to implement the first task in the issue #6.

This is my first PR for this project. If this PR is ok, I plan to implement all the tasks under this issue.

All tests are getting passed when run locally.

README.rst Outdated Show resolved Hide resolved
berserk/clients.py Show resolved Hide resolved
berserk/clients.py Outdated Show resolved Hide resolved
berserk/clients.py Outdated Show resolved Hide resolved
berserk/clients.py Outdated Show resolved Hide resolved
@kalpgarg
Copy link
Contributor Author

Thanks, @icp1994, for your suggestions. I incorporated them all in the last commit.

Copy link
Contributor

@icp1994 icp1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. There's just one line I forgot to remove in yesterday's review. After you are done, please squash/fixup your commits into one. The msg should be something like: "Add /api/bot/online endpoint"

berserk/clients.py Outdated Show resolved Hide resolved
@kalpgarg
Copy link
Contributor Author

Done @icp1994

@benediktwerner benediktwerner merged commit a6ce5fa into lichess-org:master May 13, 2023
@benediktwerner
Copy link
Member

Thanks! Release as v0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants