Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bots.handle_draw_offers and bots.handle_takeback_offers #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FriedrichtenHagen
Copy link

Checklist when adding a new endpoint
  • Added new endpoint to the README.md

  • Ensured that my endpoint name does not repeat the name of the client. Wrong: client.users.get_user(), Correct: client.users.get()

  • Typed the returned JSON using TypedDicts in berserk/types/, example
    I did not type the returned json since it is not typed in other bots endpoint methods. The response is quite minimal ({
    "ok": true
    }). I could add this (also for the other bot endpoints) if desirable.

  • Written tests for GET endpoints not requiring authentification. Documentation, example
    These endpoints require authentication.

  • Added the endpoint and your name to CHANGELOG.md in the To be released section (to be created if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant