Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary try catch as we fixed it #535

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove unnecessary try catch as we fixed it #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 9 additions & 22 deletions src/main/scala/Chess.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,39 +6,26 @@ import chess.opening.{ Opening, OpeningDb }
import chess.Square
import chess.bitboard.Bitboard
import chess.variant.{ Crazyhouse, Variant }
import com.typesafe.scalalogging.Logger
import cats.syntax.option.*

import ipc.*

object Chess:

private val logger = Logger(getClass)

def apply(req: ClientOut.AnaMove): ClientIn =
Monitor.time(_.chessMoveTime):
try
chess
.Game(req.variant.some, req.fen.some)(req.orig, req.dest, req.promotion)
.map((game, move) => makeNode(game, Uci.WithSan(Uci(move), move.san), req.path, req.chapterId))
.getOrElse(ClientIn.StepFailure)
catch
case e: java.lang.ArrayIndexOutOfBoundsException =>
logger.warn(s"${req.fen} ${req.variant} ${req.orig}${req.dest}", e)
ClientIn.StepFailure
chess
.Game(req.variant.some, req.fen.some)(req.orig, req.dest, req.promotion)
.map((game, move) => makeNode(game, Uci.WithSan(Uci(move), move.san), req.path, req.chapterId))
.getOrElse(ClientIn.StepFailure)

def apply(req: ClientOut.AnaDrop): ClientIn =
Monitor.time(_.chessMoveTime):
try
chess
.Game(req.variant.some, req.fen.some)
.drop(req.role, req.square)
.map((game, drop) => makeNode(game, Uci.WithSan(Uci(drop), drop.san), req.path, req.chapterId))
.getOrElse(ClientIn.StepFailure)
catch
case e: java.lang.ArrayIndexOutOfBoundsException =>
logger.warn(s"${req.fen} ${req.variant} ${req.role}@${req.square}", e)
ClientIn.StepFailure
chess
.Game(req.variant.some, req.fen.some)
.drop(req.role, req.square)
.map((game, drop) => makeNode(game, Uci.WithSan(Uci(drop), drop.san), req.path, req.chapterId))
.getOrElse(ClientIn.StepFailure)

def apply(req: ClientOut.AnaDests): ClientIn.Dests =
Monitor.time(_.chessDestTime):
Expand Down
Loading