Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vaults] Immutably fix the node operator in the basic StakingVault #897

Merged
merged 104 commits into from
Dec 24, 2024

Merge pull request #893 from lidofinance/feat/vaults-suggestions

2168c79
Select commit
Loading
Failed to load commit list.
Merged

[Vaults] Immutably fix the node operator in the basic StakingVault #897

Merge pull request #893 from lidofinance/feat/vaults-suggestions
2168c79
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed Dec 24, 2024 in 4s

2 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 1 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 304 in contracts/0.8.25/vaults/Dashboard.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

Dashboard.mintWstETH(address,uint256) ignores return value by STETH.approve(address(WSTETH),_tokens)

Check failure on line 34 in contracts/0.8.25/vaults/Delegation.sol

See this annotation in the file changed.

Code scanning / Slither

State variable shadowing High

Delegation.TOTAL_BASIS_POINTS shadows:
- Dashboard.TOTAL_BASIS_POINTS