[CSM v2] fix: Fulu fork epoch duties #812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Postponed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We faced an issue with eth/v1/validator/duties/proposer/{epoch} on Hoodi after Fulu fork for Lighthouse:
For example, /eth/v1/validator/duties/proposer/50700 returns "dependent_root": 0x136c16abf7ed785f6babd0ff2b779d29a3c174355c22fafd5eb801c1d81a63ac (the last slot of {epoch} - 2) in body, but it should be 0xd2b43eb8f039f728881167d117bf939a03d3e0e824c61402d76045eed28bcfa5 (the last slot of {epoch} - 1) due to https://ethereum.github.io/beacon-APIs/#/Validator/getProposerDuties.
As a second source, we used Nimbus - http://unstable.hoodi.beacon-api.nimbus.team/eth/v1/validator/duties/proposer/50700
Version: Lighthouse/v8.0.0-rc.2-b59feb0/x86_64-linux
We found no changes for this response in other nodes' source code:
Prysm - https://github.com/OffchainLabs/prysm/blob/develop/beacon-chain/rpc/eth/validator/handlers.go#L1473
Lodestar - https://github.com/ChainSafe/lodestar/blob/rc/v1.36.0/packages/state-transition/src/util/shufflingDecisionRoot.ts#L13
Nimbus - https://github.com/status-im/nimbus-eth2/blob/unstable/beacon_chain/spec/beaconstate.nim#L2814
How Has This Been Tested?
Describe how you tested the changes:
Checklist