feat: correctly handle doppelgänger pubkeys #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamtamchik
force-pushed
the
feat/fix-state
branch
from
9782710 to
22af184
Compare
F4ever
reviewed
Nov 6, 2025
F4ever
reviewed
Nov 6, 2025
F4ever
reviewed
Nov 6, 2025
| } | ||
|
|
||
| # --- Web3 Mock --- | ||
| w3_mock = MagicMock() |
Contributor
There was a problem hiding this comment.
There is a better mock, that can be used instead, in conftest.py
chasingrainbows
approved these changes
Nov 6, 2025
F4ever
approved these changes
Nov 7, 2025
Member
|
One integration test fails - expected. Will be fixed after protocol upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix doppelgänger pubkeys acceptance for TV calculations.
Initial State
Vault1: 1 ETH balanceVault2: 32 ETH balanceAttack Sequence
Step 1: External Predeposit to validator1
Predeposit validator1 using external ETH (not from PDG)
Validator1 configured with vault1's withdrawal credentials (WC1)
Status: Pending validator
vault1 totalValue: 1 ETH (unchanged, since PDG state = None)
Step 2: PDG Predeposit to Same Validator
Use PDG to predeposit to validator1 again
This time with vault2's withdrawal credentials (WC2)
Deposit: 1 ETH from vault2, stage remaining 31 ETH
vault2 totalValue: 31 ETH (32 - 1 = 31, since validator doesn't point to vault2 yet)
Step 3: The Exploit
vault1 totalValue becomes 2 ETH!
Why?
vault1 still has 1 ETH in balance
validator1 now has PDG state = PREDEPOSITED (with WC2)
BUT: System incorrectly attributes the predeposited validator to vault1 because it was originally associated with WC1
vault1 gains +1 ETH credit for the predeposited validator
Step 4: Borrow and Compensate Race
vault1 borrows against the inflated 2 ETH totalValue
System then compensates vault2 for the staged ETH
vault2 totalValue: Returns to 32 ETH
vault1 totalValue: Drops back to 1 ETH (but debt already issued)
Result: Bad debt created
Step 5: Parallel Exploitation
Repeat steps 1-4 multiple times in parallel to amplify bad debt creation.
Root Cause
The system fails to properly handle validator credential switches, allowing double-counting of validator value across vaults during the window between predeposit and compensation.
Related Issue/Task
How Has This Been Tested?
Describe how you tested the changes:
pytest)Checklist
CSM_STATE_VERSIONis bumped (if the new version affects data in the cache)