Fix requirements to point to pyserial, rather than serial #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #6
Been coming across an issue where upon restarting HA I get the error
ImportError: cannot import name 'Serial' from 'serial' (/usr/local/lib/python3.12/site-packages/serial/__init__.py)This is also happening on the forum here: https://community.home-assistant.io/t/cambridge-audio-cxn-and-cxa-media-player/175992/42
Doing a
pip install pyserial --force-reinstallwithin the container seems to fix it.Upon further investigation, I can see the integration relies on
serial(A framework for serializing/deserializing JSON/YAML/XML into python class instances and vice versa), rather thanpyserial.As such, I've gone and updated the requirements.
This seems to have fixed my issue in between HA restarts.
Thanks for making this integration! :)