Add assertion to verify preprocessor was run on create-ref modifier #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jasonbekolay, thank you for report! Technically it's completely allowed to use ref-bucket without preprocessor, but I agree it's barely a real use-case and could lead into issues as mentioned. I'm afraid if we land change as-is we could break flow for users if already used with this behaviour. Could we replace |
Co-authored-by: Cyril Fluck <[email protected]>
|
Updated 👍 I've also changed it not warn if the |
lifeart
approved these changes
Dec 13, 2023
|
@jasonbekolay thank you for your work! |
|
Thanks for the quick merge and release 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team uses
ember-ref-bucketin one of our private addons and an app that uses that addon. We did not haveember-ref-bucketin the dependencies for the app, which caused an issue where we could usecreate-refbut the bucket was set incorrectly because the preprocessor was not running on the app code.This took us a while to debug. The assertion in this PR would provide immediate feedback in development/test and the action to take to resolve. I'm happy to change this if you have any feedback.
Thanks for your work on this addon!