Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temporary fork of client-oauth2 to loosen up pathname check.. #19

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

Druotic
Copy link

@Druotic Druotic commented Dec 30, 2019

there's an open PR here - mulesoft-labs/js-client-oauth2#130
That change removes the unnecessary check, but this provides some
flexibility if there are redirects in the auth flow.

This should be temporary until the PR is merged and released but it allows us to make progress and use the new changes without waiting.

there's an open PR here - mulesoft-labs/js-client-oauth2#130
That change removes the unnecessary check, but this provides some
flexibility if there are redirects in the auth flow.
"query-string": "^6.2.0"
},
"devDependencies": {
"@types/jest": "^23.3.10",
"@types/node": "^13.1.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that locally link would break the typings without this. Not strictly necessary, but makes local development easier.

@Druotic
Copy link
Author

Druotic commented Dec 31, 2019

Merging with only one approval since the general approach has already been discussed offline, I'll bump a patch version since this only loosens strictness on the redirectUri.

@Druotic Druotic merged commit ac233ef into master Dec 31, 2019
@hemp hemp deleted the use-temp-fork-loosened-pathname-check-client-oauth2 branch July 24, 2020 11:17
@hemp hemp restored the use-temp-fork-loosened-pathname-check-client-oauth2 branch July 24, 2020 11:17
@swain swain deleted the use-temp-fork-loosened-pathname-check-client-oauth2 branch June 2, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants