Use temporary fork of client-oauth2 to loosen up pathname check.. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's an open PR here - mulesoft-labs/js-client-oauth2#130 That change removes the unnecessary check, but this provides some flexibility if there are redirects in the auth flow.
Druotic
commented
Dec 30, 2019
| "query-string": "^6.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^23.3.10", | ||
| "@types/node": "^13.1.2", |
There was a problem hiding this comment.
I found that locally link would break the typings without this. Not strictly necessary, but makes local development easier.
ctdio
approved these changes
Dec 31, 2019
|
Merging with only one approval since the general approach has already been discussed offline, I'll bump a patch version since this only loosens strictness on the redirectUri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's an open PR here - mulesoft-labs/js-client-oauth2#130
That change removes the unnecessary check, but this provides some
flexibility if there are redirects in the auth flow.
This should be temporary until the PR is merged and released but it allows us to make progress and use the new changes without waiting.