[LPD-40485 Ehcache] LPD-41245 Upgrade to Ehcache 3 #7721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… listener factory # breaking ## What modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/configuration/PortalCacheManagerConfiguration.java Constructor parameter `portalCacheManagerListenerPropertiesSet` and method `getPortalCacheManagerListenerPropertiesSet` are removed from the class. ## Why These, as well as the support for declaring a portal cache manager listener factory in the Ehcache XML configuration file and getting it processed by Liferay is removed as a preparation of upgrading to Ehcache 3. Ehcache 3 no longer supports declaring cache manager event listener factory in XML configurations. ## Alternatives Register custom `PortalCacheManagerListener` implementation using `PortalCacheManager.registerPortalCacheManagerListener(PortalCacheManagerListener)`. ---- # breaking ## What modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/PortalCacheManagerListenerFactory.java `modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/PortalCacheManagerListenerFactory.java` is removed. ## Why These, as well as the support for declaring a portal cache manager listener factory in the Ehcache XML configuration file and getting it processed by Liferay is removed as a preparation of upgrading to Ehcache 3. Ehcache 3 no longer supports declaring cache manager event listener factory in XML configurations. ## Alternatives Register custom `PortalCacheManagerListener` implementation using `PortalCacheManager.registerPortalCacheManagerListener(PortalCacheManagerListener)`. ----
…r factory # breaking ## What modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/configuration/PortalCacheConfiguration.java Method `getPortalCacheListenerPropertiesSet()` is replaced by `getPortalCacheReplicatorPropertiesSet()`. ## Why These, as well as the support for declaring a portal cache listener factory in the Ehcache XML configuration file and getting it processed by Liferay is removed as a preparation of upgrading to Ehcache 3. Ehcache 3 no longer supports declaring cache event listener factory in XML configurations. The method name is updated to reflect the change and show that the properties set now only serves `PortalCacheReplicator` configurations. ## Alternatives Register custom `PortalCacheListener` implementation using `PortalCache#registerPortalCacheListener` methods. ---- # breaking ## What modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/PortalCacheListenerFactory.java `modules/apps/portal-cache/portal-cache-api/src/main/java/com/liferay/portal/cache/PortalCacheListenerFactory.java` is removed. ## Why These, as well as the support for declaring a portal cache listener factory in the Ehcache XML configuration file and getting it processed by Liferay is removed as a preparation of upgrading to Ehcache 3. Ehcache 3 no longer supports declaring cache event listener factory in XML configurations. ## Alternatives Register custom `PortalCacheListener` implementation using `PortalCache#registerPortalCacheListener` methods. ----
…ault cache configuration from the "default" template, and provide a method to derive a builder from the default configuration for later usage.
…aces and classes to adapt to Ehcache 3's internal statistic service
…Ehcache configuration overriding, supply an ExecutionService that runs tasks on the caller thread for event listeners, and supply a StatisticsService for management.
… Ehcache 3, use the default configuration when the Ehcache is not pre-created by the XML configurations.
…eep support for per-item TTL
…ners by ourselves
|
CI is automatically triggering the following test suites:
|
|
ci:test:relevant |
|
ci:test:clustering |
|
ci:test:core-functional |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-41245-upgrade-to-ehcache3 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6918 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-core-infra#7721 Testray Routine:EE Pull Request Testray Build ID:87251026 Testray Importer:publish-testray-report#27093 |
❌ ci:test:core-functional - 194 out of 224 jobs passed in 1 hour 46 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 5fe2861239e84ecd0758b51a9708e4249c8405d4 ci:test:core-functional - 194 out of 224 jobs PASSED30 Failed Jobs:
194 Successful Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here.Test bundle downloads: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6995 Jenkins Report:jenkins-report.html Jenkins Suite:core-functional Pull Request:liferay-core-infra#7721 Testray Routine:EE Pull Request Testray Build:[master] ci:test:core-functional - dantewang > liferay-core-infra - PR#7721 - 2024-12-08[19:08:37] Testray Build ID:87256574 Testray Importer:publish-testray-report#25674 |
|
ci:report:87254104 |
|
ci:report:87256574 |
liferay-continuous-integration
added
ci:test - pending
and removed
ci:test - pending
labels
Build completed.Testray CSV has been generated successfully for testrayBuildID: 87254104. Job Link: generate-testray-csv Testray CSV Link: testray-results-87254104.csv |
liferay-continuous-integration
added
ci:test - success
and removed
ci:test - pending
labels
Build completed.Testray CSV has been generated successfully for testrayBuildID: 87256574. Job Link: generate-testray-csv Testray CSV Link: testray-results-87256574.csv |
liferay-continuous-integration
added
ci:test - success
and removed
ci:test - success
labels
… to remove; fire remove event by ourselves, because multi-vm cache replication depends on it.
dantewang
force-pushed
the
LPD-41245-upgrade-to-ehcache3
branch
from
3b9589a to
31c5015
Compare
|
ci:test:clustering |
liferay-continuous-integration
added
ci:test:clustering - pending
and removed
ci:test:clustering - failure
labels
No unique failure in non-cluster core-functional tests. Will double check clustering tests in the latest clustering run. |
liferay-continuous-integration
added
ci:test:clustering - failure
and removed
ci:test:clustering - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#19091 Jenkins Report:jenkins-report.html Jenkins Suite:clustering Pull Request:liferay-core-infra#7721 Testray Routine:EE Pull Request Testray Build:[master] ci:test:clustering - dantewang > liferay-core-infra - PR#7721 - 2024-12-08[22:21:59] Testray Build ID:87278022 Testray Importer:publish-testray-report#41303 |
No unique failure in clustering. |
|
Please resolve conflicts so we can continue reviewing and processing. Created by |
PR_Conflicts_Alert[bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #7720