[Unify Lib] LPD-46920 Unify scribejava #7896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the javax usage of this lib.
|
CI is automatically triggering the following test suites:
|
|
ci:test:poshi |
|
ci:test:relevant |
Build completed.Jenkins URL: test-portal-acceptance-pullrequest(master) The Please use |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#5908 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-core-infra#7896 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - dantewang > liferay-core-infra - PR#7896 - 2025-01-21[19:11:02] Testray Build ID:115333634 Testray Importer:publish-testray-report#35877 |
❌ ci:test:sf - 0 out of 1 jobs passed in 31 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46920-unify-scribejava-1-22 1 Failed Jobs:For more details click here.format-source-files:
[java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
[java] java.lang.Exception: Found 10 formatting issues:
[java] 1: ./modules/third-party/org-hibernate-core-3.6.10/build.gradle expected:<...sion: "3.2.0.Final"
[java] [
[java] ] compileOnly group: ...> but was:<...sion: "3.2.0.Final"
[java] [] compileOnly group: ...>
[java] 2: ./modules/third-party/org-drools-core/build.gradle expected:<...sion: "5.4.0.Final"
[java] [
[java] ] compileOnly group: ...> but was:<...sion: "5.4.0.Final"
[java] [] compileOnly group: ...>
[java] 3: ./modules/third-party/org-outerj-daisy-diff/build.gradle expected:<...ff", version: "1.2"
[java] [
[java] ] compileOnly group: ...> but was:<...ff", version: "1.2"
[java] [] compileOnly group: ...>
[java] 4: ./modules/third-party/org-apache-axis/build.gradle expected:<...", version: "1.6.3"
[java] [
[java] ] compileOnly group: ...> but was:<...", version: "1.6.3"
[java] [] compileOnly group: ...>
[java] 5: ./modules/third-party/jenkins-core/build.gradle expected:<...", version: "3.0.1"
[java] [
[java] ] compileOnly group: ...> but was:<...", version: "3.0.1"
[java] [] compileOnly group: ...>
[java] 6: ./modules/third-party/org-opensearch-java-client/build.gradle expected:<... version: "2.25.53"
[java] [
[java] ] compileOnly group: ...> but was:<... version: "2.25.53"
[java] [] compileOnly group: ...>
[java] 7: ./modules/third-party/org-opensearch-rest-client/build.gradle expected:<..., version: "4.4.15"
[java] [
[java] ] compileOnly group: ...> but was:<..., version: "4.4.15"
[java] [] compileOnly group: ...>
[java] 8: ./modules/sdk/gradle-plugins-alloy-taglib/src/gradleTest/smoke/build.gradle expected:<..."org.apache.commons.[configuration", version: "1.10.LIFERAY-PATCHED-2"
[java] alloyTaglib group: "com.liferay", name: "org.apache.commons.logging", version: "1.2.LIFERAY-PATCHED-2"
[java] alloyTaglib group: "com.liferay", name: "org.freemarker", version: "2.3.33.LIFERAY-PATCHED-2"
[java] alloyTaglib group: "com.liferay.alloy-taglibs", name: "alloy-taglib", version: "1.1.14"
[java] alloyTaglib group: "com.liferay.portal", name: "com.liferay.portal.impl", version: "2.16.0"
[java] alloyTaglib group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "2.32.0" |
|
Jenkins Build:test-portal-source-format#7296 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-core-infra#7896 Testray Routine:EE Pull Request Testray Build ID:115339948 Testray Importer:publish-testray-report#27789 |
liferay-continuous-integration
added
ci:test:poshi - success
and removed
ci:test:poshi - pending
labels
✔️ ci:test:poshi - 32 out of 32 jobs passed in 1 hour 9 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 215d6c77bb0fda96d716caef23e7366bf21935a0 ci:test:poshi - 32 out of 32 jobs PASSED32 Successful Jobs:
For more details click here.Test bundle downloads: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#10805 Jenkins Report:jenkins-report.html Jenkins Suite:poshi Pull Request:liferay-core-infra#7896 Testray Routine:EE Pull Request Testray Build:[master] ci:test:poshi - dantewang > liferay-core-infra - PR#7896 - 2025-01-21[19:10:54] Testray Build ID:115361089 Testray Importer:publish-testray-report#25585 |
|
@tinatian Relevant will not run since I only modified poshi-runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tinatian I didn't update this lib to latest because 6.6.3 is enough to avoid the javax usage. The lib has a compileInclude usage in osb-faro-web so I would like to leave the dependency centralization to other team.