-
Notifications
You must be signed in to change notification settings - Fork 504
feat(@clayui/css): LPD-51801 Adds .blockquote variant for .form-text #6059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pat270 ... In looking at the gif, it appears that spacing between the input and the text does not match what is in the figma. Could you update that? Also make sure the spacing is correct when there is an input description or an error as well.
Additionally, this should be added to the story book and to the forms documentation page.
Thanks.
@ethib137 this should be good to go. We have no way of inserting an error message before the default text. We will need to add that feature if needed. |
@pat270 can you add this to the forms documentation page? |
- ClayForm.Group should be used with a group of inputs. We shouldn't force this by default.
@ethib137 I removed the use of Edit: Another thing to note is clayui.com updates won't appear until we release a new version. |
Hey @pat270 this still looks like it hasn't been added to the forms documentation page. It's only been added to the LocalizedInput docs page. Please could you add it to the forms documentation page, since this is built using the |
https://liferay.atlassian.net/browse/LPD-51801
Not sure if I implemented this correctly, but it looks like they just want a style change?