Skip to content

feat(@clayui/css): LPD-51801 Adds .blockquote variant for .form-text #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented May 14, 2025

https://liferay.atlassian.net/browse/LPD-51801

localized-input1

Not sure if I implemented this correctly, but it looks like they just want a style change?

Copy link
Member

@ethib137 ethib137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pat270 ... In looking at the gif, it appears that spacing between the input and the text does not match what is in the figma. Could you update that? Also make sure the spacing is correct when there is an input description or an error as well.

Additionally, this should be added to the story book and to the forms documentation page.

Thanks.

@pat270
Copy link
Member Author

pat270 commented May 16, 2025

@ethib137 this should be good to go. We have no way of inserting an error message before the default text. We will need to add that feature if needed.

spacing

@ethib137
Copy link
Member

Thanks @pat270 ... In looking at the gif, it appears that spacing between the input and the text does not match what is in the figma. Could you update that? Also make sure the spacing is correct when there is an input description or an error as well.

Additionally, this should be added to the story book and to the forms documentation page.

Thanks.

@pat270 can you add this to the forms documentation page?

    - ClayForm.Group should be used with a group of inputs. We shouldn't force this by default.
@pat270
Copy link
Member Author

pat270 commented May 20, 2025

@ethib137 I removed the use of ClayForm.Group from LocalizedInput. It should only be used by the dev when composing a form group. Teams are overriding the margin-bottom in the DXP use case.

form-group

Edit: Another thing to note is clayui.com updates won't appear until we release a new version.

@ethib137
Copy link
Member

Hey @pat270 this still looks like it hasn't been added to the forms documentation page. It's only been added to the LocalizedInput docs page. Please could you add it to the forms documentation page, since this is built using the <ClayForm.Text> component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants