fix: test errors #78
fix: test errors #78
Conversation
myz1237
commented
Nov 4, 2024
•
myz1237
commented
- Remove all tests to check if explorers are accessible. Reason: some fetch may fail every time when we run the test.
- Remove unavailable rps
|
|
| expect(response.url).toBe(blockExplorerUrl) | ||
| expect(response.ok).toBe(true) | ||
| expect(isSameUrl(blockExplorerUrl, response.url)).toBeTruthy() | ||
| expect(response.ok).toBeTruthy() |
There was a problem hiding this comment.
hmm what is ok in that case? Because 'false' is truthy, so do we really want this behaviour?
There was a problem hiding this comment.
- To be honest, I do not wanna this test cases for solana, evm and utxo, since the test really calls external service, which are unstable, that's the reason why we fail at most of time.
Any input @chybisov You added these tests, is it fine to remove it and just check if the url is legal or not?
There was a problem hiding this comment.
@chybisov Do we wanna remove it? Otherwise the test does not work.
There was a problem hiding this comment.
Solana explorers should pass tests fine, there were some issues with Bitcoin ones. Would you like to remove these checks completely?
There was a problem hiding this comment.
yes, I wanna remove them completely, and just ensure the rpc and explorer array are not empty.
Normally, we add multiple rpcs, some of them may be invalid, or we are blocked. Same to explorer, the explorer could refuse our request, which are unstable.
what do you think of it?
There was a problem hiding this comment.
I have removed all tests about the block explorer links
|
Any updates @myz1237 ? |
| @@ -35,7 +35,6 @@ export const supportedEVMChains: EVMChain[] = [ | |||
| 'https://ethereum-rpc.publicnode.com', | |||
| 'https://eth.drpc.org', | |||
| 'https://eth.public-rpc.com', | |||
| 'https://mainnet.infura.io/v3/9aa3d95b3bc440fa88ea12eaa4456161', | |||
There was a problem hiding this comment.
key is invalid now
| @@ -794,7 +793,6 @@ export const supportedEVMChains: EVMChain[] = [ | |||
| 'https://mantle-rpc.publicnode.com', | |||
| 'https://mantle.drpc.org', | |||
| 'https://mantle.public-rpc.com', | |||
| 'https://rpc.ankr.com/mantle', | |||
|
If this pr is merged, please set the merge policy: only allowed to merge if all actions succeed |
