Merge pull request #1918 from lift/ajk-log-exceptions

Log exceptions too when logging errors
lift · Sep 15, 2017 · aa24c2d · aa24c2d
2 parents c97b7ea + 7bea36b
commit aa24c2d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/core/util/src/main/scala/net/liftweb/util/Schedule.scala b/core/util/src/main/scala/net/liftweb/util/Schedule.scala
@@ -151,7 +151,7 @@ sealed trait Schedule extends Loggable {
           try {
             f.apply()
           } catch {
-            case e: Exception => logger.error(e)
+            case e: Exception => logger.error(e.getMessage, e)
           }
         }
       }
@@ -162,7 +162,7 @@ sealed trait Schedule extends Loggable {
             Schedule.this.restart
             pool.execute(r)
           } catch {
-            case e: Exception => logger.error(e)
+            case e: Exception => logger.error(e.getMessage, e)
           }
         }
       }

diff --git a/web/webkit/src/main/scala/net/liftweb/builtin/snippet/Embed.scala b/web/webkit/src/main/scala/net/liftweb/builtin/snippet/Embed.scala
@@ -79,6 +79,10 @@ object Embed extends DispatchSnippet {
 
       bindFn(template)
     }
+    case Failure(msg, Full(ex), _) =>
+      logger.error("'embed' snippet failed with message: "+msg, ex)
+      throw new SnippetExecutionException("Embed Snippet failed: "+msg)
+
     case Failure(msg, _, _) =>
       logger.error("'embed' snippet failed with message: "+msg)
       throw new SnippetExecutionException("Embed Snippet failed: "+msg)

diff --git a/web/webkit/src/main/scala/net/liftweb/http/LiftSession.scala b/web/webkit/src/main/scala/net/liftweb/http/LiftSession.scala
@@ -2106,6 +2106,7 @@ class LiftSession(private[http] val _contextPath: String, val underlyingId: Stri
           in.!(xlate(p) match {
             case Full(v) => v
             case Empty => logger.error("Failed to deserialize JSON message "+p); p
+            case Failure(msg, Full(ex), _) => logger.error("Failed to deserialize JSON message "+p+". Error "+msg, ex); p
             case Failure(msg, _, _) => logger.error("Failed to deserialize JSON message "+p+". Error "+msg); p
           })
           JsCmds.Noop