This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Drop v1beta1 crds for k8s 122 compliance #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and streamlet-name
This reverts commit 47289fd.
thomasschoeftner
commented
Jul 2, 2022
thomasschoeftner
commented
Jul 2, 2022
thomasschoeftner
commented
Jul 2, 2022
core/cloudflow-operator/src/main/scala/cloudflow/operator/Main.scala
Outdated
Show resolved
Hide resolved
|
@RayRoestenburg - any chance you could take a look, pls. |
|
I'll have a look at it @thomasschoeftner |
Thank you, @franciscolopezsancho ! - I'm not sure whether the changes in |
scpcy
approved these changes
Jul 6, 2022
|
@franciscolopezsancho Do you have any updates on this? |
|
thanks @franciscolopezsancho I think now these issues are obsolete:
Can somebody confirm this, pls? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I've tried to get rid of
v1beta1CRD in the Cloudflow code base.Why are the changes needed?
With Kubernetes 1.22 support for
v1beta1CRDs is removed and Cloudflow will not be deployable anymore.The issue had already been raised by another user: #1199
Does this PR introduce any user-facing change?
no
How was this patch tested?
I do not have an appropriate environment at the moment to verify the change.