Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): document how to perform auto-formatting #258

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Mar 22, 2022

No description provided.

@github-actions github-actions bot added the kalix-runtime Runtime and SDKs sub-team label Mar 22, 2022
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren
Copy link
Contributor

Failure is some NPM security issue audit finding packages to update

@raboof
Copy link
Contributor Author

raboof commented Mar 22, 2022

Failure is some NPM security issue audit finding packages to update

yeah, should get fixed with #259

we should probably set up a nightly/periodic job to check for those, filed #260

CONTRIBUTING.md Outdated

Auto-update formatting with:

prettier --config .prettierrc 'sdk/**/*.{js,ts}' 'tck/**/*.{js,ts}' 'npm-js/**/*.{js,ts}' --write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a scripted task already set up for this:

https://github.com/lightbend/akkaserverless-javascript-sdk/blob/9553e4f904d91ceccdfa8ef98c8a4a35543b9447/package.json#L15

So could just be npm run prettier-format in the root directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... maybe it's trivial then, but perhaps still good to mention auto-formatting is a thing.

@raboof raboof force-pushed the document-formatting branch from 4aaf37e to b9d4b5b Compare March 23, 2022 07:32
@johanandren johanandren merged commit 564e647 into lightbend:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants