remove unspecified option from annotation

lightbend · Dec 18, 2023 · a3bfebe · a3bfebe
1 parent d8b2359
commit a3bfebe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/sdk/java-sdk-spring/src/main/java/kalix/javasdk/annotations/Trigger.java b/sdk/java-sdk-spring/src/main/java/kalix/javasdk/annotations/Trigger.java
@@ -28,8 +28,6 @@
 @Documented
 public @interface Trigger {
   enum TriggerEvent {
-    UNSPECIFIED,
-
     /**
      * The on startup hook is called every time a service instance boots up.
      * This can happen for very different reasons: restarting / redeploying the service,
@@ -44,7 +42,7 @@ enum TriggerEvent {
   /**
    * The service life-cycle event for which this hook will be triggered.
    */
-  TriggerEvent on() default TriggerEvent.UNSPECIFIED;
+  TriggerEvent on();
 
   /**
    * The maximum number of retries we will do upon failure of the method hook calls.

diff --git a/sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/ActionDescriptorFactory.scala b/sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/ActionDescriptorFactory.scala
@@ -66,14 +66,10 @@ private[impl] object ActionDescriptorFactory extends ComponentDescriptorFactory
   private def triggerOptions(javaMethod: Method): Option[TriggerOptions] = {
     condOpt(hasTriggerMethodOptions(javaMethod)) { case true =>
       val ann = javaMethod.getAnnotation(classOf[Trigger]);
-      val triggerEvent = ann.on() match {
-        case Trigger.TriggerEvent.UNSPECIFIED => TriggerOptions.TriggerEvent.UNSPECIFIED
-        case Trigger.TriggerEvent.STARTUP     => TriggerOptions.TriggerEvent.STARTUP
-      }
 
       TriggerOptions
         .newBuilder()
-        .setOn(triggerEvent)
+        .setOn(TriggerOptions.TriggerEvent.STARTUP) // this is the only event available at the moment
         .setMaxRetries(ann.maxRetries())
         .build()
     }