feat: typed component client #1685

aludwiko · 2023-06-16T09:02:35Z

References #1335

Ready for review, in the following PRs I'm planning to:

support Workflows
clean the double URI Uri construction
add more specific tests, params with null values, etc.
document it
compound keys/ids support, TBD

sdk/java-sdk-spring/src/main/java/kalix/spring/ActionCallBuilder.java

aludwiko · 2023-06-20T10:17:43Z

Back to draft again, one more issue with encoding :/

sdk/java-sdk-spring/src/main/scala/kalix/spring/impl/RestKalixClientImpl.scala

aludwiko · 2023-06-20T12:42:04Z

ready for review again

aludwiko · 2023-06-20T13:09:23Z

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/client/ComponentCall.scala

+ * limitations under the License.
+ */
+
+package kalix.javasdk.impl.client


I'm not sure about packaging here and for MethodRefResolver

MethodRefResolver should stay in impl as it is not directly exposed to end users, if I'm not mistaken.

On the other hand, ComponentCall to ComponentCall22 must be public and we need to offer guarantees. Also good if we make them final.

ComponentCall still need to move to public package. It's user land api.

final added

that's a bit problematic, because it's a scala code, or you mean to just change the package name?

do you think I should rewrite it in Java?

ok, moved to a proper package

sdk/java-sdk-spring/src/test/java/kalix/spring/ComponentClientTest.java

aludwiko · 2023-06-22T12:22:30Z

sdk/java-sdk-spring/src/main/scala/kalix/spring/impl/RestKalixClientImpl.scala

@@ -16,12 +16,15 @@

 package kalix.spring.impl


Ok ready for review, I simplified the old code a bit and add separate methods for the typed client.

…-kalixclient # Conflicts: # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/TransferWorkflow.java # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/TransferWorkflowWithFraudDetection.java # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/TransferWorkflowWithoutInputs.java # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/WorkflowWithDefaultRecoverStrategy.java # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/WorkflowWithRecoverStrategy.java # sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/WorkflowWithTimeout.java # sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/EntityDescriptorFactory.scala

octonato

Looking good. I left a few comments.

I will do a second pass after lunch.

octonato · 2023-06-23T09:28:54Z

sdk/java-sdk-spring/src/main/java/kalix/spring/ComponentClient.java

+    return new ActionCallBuilder(kalixClient);
+  }
+
+  public ValueEntityCallBuilder forValueEntity() {


Is that variant intended for methods annotated with @GenerateId?

octonato · 2023-06-23T09:36:50Z

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/client/ComponentCall.scala

+ * limitations under the License.
+ */
+
+package kalix.javasdk.impl.client


ComponentCall still need to move to public package. It's user land api.

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/reflection/EntityKeyExtractor.scala

octonato · 2023-06-23T09:42:47Z

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/reflection/EntityKeyExtractor.scala

+    val entityKeysOnType = idValue(component)
+    val entityKeyOnMethod = idValue(method)
+


for our own sanity, we should call it entityIds..

yeah, copy paste from the source before the renaming

And class should be IdExtractor.scala. We can remove the entity prefix in all places.

sdk/java-sdk-spring/src/main/scala/kalix/spring/impl/KalixSpringApplication.scala

sdk/java-sdk-spring/src/test/java/kalix/spring/ComponentClientTest.java

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/impl/http/HttpEndpointMethodDefinition.scala

octonato · 2023-06-23T10:44:24Z

sdk/java-sdk-spring/src/main/java/kalix/spring/WorkflowCallBuilder.java

I realise now that they are all under kalix.spring. It should be under kalix.javasdk instead.

sdk/java-sdk-spring/src/main/scala/kalix/spring/impl/RestKalixClientImpl.scala

sdk/java-sdk-spring/src/main/java/kalix/spring/ComponentClient.java

sdk/java-sdk-spring/src/main/java/kalix/spring/EventSourcedEntityCallBuilder.java

octonato

LGTM, with some minor suggestions and change requests. Good for merge after that.

sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/ComponentClient.java

octonato · 2023-06-26T15:12:24Z

sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/ComponentClient.java

+ * <pre>{@code
+ * public Effect<String> createUser(String userId, String email, String name) {
+ *   //validation here
+ *   var defCall = componentClient.forValueEntity(userId).call(UserEntity::createUser).params(email, name);


Nice to have this example code. 💯

We are using pure java, but that's not a common style. Good to have a clear example.

sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/ComponentClient.java

sdk/java-sdk-spring/src/main/scala/kalix/javasdk/client/ComponentCall.scala

…ntClient.java Co-authored-by: Renato Cavalcanti <[email protected]>

feat: typed component client

0341a0e

aludwiko linked an issue Jun 16, 2023 that may be closed by this pull request

Spring SDK: Typed KalixClient #1335

Closed

github-actions bot added java-sdk kalix-runtime Runtime and SDKs sub-team labels Jun 16, 2023

using ComponentClient in IT tests

c0af818

github-actions bot added the java-sdk-protobuf label Jun 20, 2023

fmt

38a9779

aludwiko marked this pull request as ready for review June 20, 2023 09:28

aludwiko commented Jun 20, 2023

View reviewed changes

sdk/java-sdk-spring/src/main/java/kalix/spring/ActionCallBuilder.java Outdated Show resolved Hide resolved

aludwiko marked this pull request as draft June 20, 2023 10:17

aludwiko added 2 commits June 20, 2023 14:00

fixing encoding

b40ca7b

fixing entity keys extraction

0c63697

aludwiko commented Jun 20, 2023

View reviewed changes

sdk/java-sdk-spring/src/main/scala/kalix/spring/impl/RestKalixClientImpl.scala Outdated Show resolved Hide resolved

aludwiko marked this pull request as ready for review June 20, 2023 12:42

more methods with arguments

775e36c

aludwiko commented Jun 20, 2023

View reviewed changes

aludwiko added 3 commits June 21, 2023 12:53

invoke -> params rename

b2cd719

unit testing component client

1db78aa

missing deps

1c93859

aludwiko commented Jun 21, 2023

View reviewed changes

sdk/java-sdk-spring/src/test/java/kalix/spring/ComponentClientTest.java Outdated Show resolved Hide resolved

aludwiko added 4 commits June 21, 2023 18:25

jupiter dep

43cdcaf

typed version of deferred call composition

e92e567

fmt

9a3c284

removing duplicated encoding

4618fce

aludwiko commented Jun 22, 2023

View reviewed changes

aludwiko added 3 commits June 22, 2023 15:56

basic null checks

bb3aee5

updating implementation to work with new annotations

4b93927

octonato reviewed Jun 23, 2023

View reviewed changes

aludwiko added 3 commits June 23, 2023 12:04

workflow support

bda88ad

PR comments

e1e85fa

docs

46486f9

octonato reviewed Jun 23, 2023

View reviewed changes

aludwiko added 4 commits June 23, 2023 13:08

PR comments

d3ea433

comment removed

9d15aa0

missing tests for descriptors with generated id

21f6fee

moving component client to public package

e486d35

aludwiko requested a review from octonato June 26, 2023 06:53

octonato approved these changes Jun 26, 2023

View reviewed changes

aludwiko and others added 5 commits June 27, 2023 09:02

Update sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/Compone…

aba7742

…ntClient.java Co-authored-by: Renato Cavalcanti <[email protected]>

Update sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/Compone…

52e6865

…ntClient.java Co-authored-by: Renato Cavalcanti <[email protected]>

Update sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/Compone…

fd4b709

…ntClient.java Co-authored-by: Renato Cavalcanti <[email protected]>

Update sdk/java-sdk-spring/src/main/java/kalix/javasdk/client/Compone…

c5943ba

…ntClient.java Co-authored-by: Renato Cavalcanti <[email protected]>

additional documentation

8a201cf

octonato merged commit b85f29a into main Jun 27, 2023
65 checks passed

octonato deleted the 1335-spring-sdk-typed-kalixclient branch June 27, 2023 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: typed component client #1685

feat: typed component client #1685

aludwiko commented Jun 16, 2023 •

edited

Loading

aludwiko commented Jun 20, 2023

aludwiko commented Jun 20, 2023

aludwiko Jun 20, 2023

octonato Jun 20, 2023 •

edited

Loading

octonato Jun 23, 2023

aludwiko Jun 23, 2023

aludwiko Jun 23, 2023

aludwiko Jun 23, 2023

aludwiko Jun 26, 2023

aludwiko Jun 22, 2023 •

edited

Loading

octonato left a comment

octonato Jun 23, 2023

aludwiko Jun 23, 2023

octonato Jun 23, 2023

octonato Jun 23, 2023

aludwiko Jun 23, 2023

octonato Jun 23, 2023

aludwiko Jun 23, 2023

octonato Jun 23, 2023

octonato left a comment

octonato Jun 26, 2023

		val entityKeysOnType = idValue(component)
		val entityKeyOnMethod = idValue(method)

feat: typed component client #1685

feat: typed component client #1685

Conversation

aludwiko commented Jun 16, 2023 • edited Loading

aludwiko commented Jun 20, 2023

aludwiko commented Jun 20, 2023

Choose a reason for hiding this comment

octonato Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aludwiko Jun 22, 2023 • edited Loading

Choose a reason for hiding this comment

octonato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octonato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aludwiko commented Jun 16, 2023 •

edited

Loading

octonato Jun 20, 2023 •

edited

Loading

aludwiko Jun 22, 2023 •

edited

Loading