fix: support metadata in deferred calls execution #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
aludwiko
commented
Jun 30, 2023
| | private <Req, Res> SingleResponseRequestBuilder<Req, Res> addHeaders(SingleResponseRequestBuilder<Req, Res> requestBuilder, Metadata metadata){ | ||
| | var updatedBuilder = requestBuilder; | ||
| | for (Metadata.MetadataEntry entry: metadata){ | ||
| | if (entry.isText()) { |
There was a problem hiding this comment.
Actually, maybe for grpc based sdk, I should support binary headers as well?
There was a problem hiding this comment.
I think we can skip those for now.
aludwiko
commented
Jun 30, 2023
| @@ -47,7 +48,7 @@ public void tearDown() throws Exception { | |||
| // tag::initialize[] | |||
| @Test | |||
| public void initializeCartTest() throws ExecutionException, InterruptedException, TimeoutException { | |||
| when(shoppingCartService.create(notNull())) | |||
| when(shoppingCartService.create().invoke(notNull())) | |||
There was a problem hiding this comment.
Under the hood we have:
(Metadata metadata) -> addHeaders(((com.example.shoppingcart.ShoppingCartServiceClient) getGrpcClient(com.example.shoppingcart.ShoppingCartService.class)).create(), metadata).invoke(createCart)
thanks to RETURNS_DEEP_STUBS I was able to fix it in the java version, but with mockito scala I'm not sure if this is an option.
Maybe we shouldn't encourage users to write unit tests for side effects. Personally I would go with IT tests for such cases.
octonato
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1702