Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing kalix dependency from Spring grpc client #1765

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: removing kalix dependency from Spring grpc client #1765

merged 3 commits into from
Aug 23, 2023

Conversation

aludwiko
Copy link
Contributor

in the documentation, we inform users to remove all Kalix annotations and imports from proto files, so I don't see any point to keep the dependency to the sdk

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team labels Aug 17, 2023
efgpinto
efgpinto approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@johanandren johanandren merged commit 2135ead into main Aug 23, 2023
65 checks passed
@johanandren johanandren deleted the chore-fixing-spring-client-documentation branch August 23, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efgpinto efgpinto efgpinto approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to the documentation java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aludwiko @efgpinto @johanandren