fix: respecting TypeName annotations when using eventing testkit #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java-sdk
java-sdk-protobuf
kalix-runtime
github-actions
bot
added
the
Documentation
aludwiko
commented
Aug 25, 2023
| */ | ||
| static <T> Message<T> of(T payload, Metadata metadata) { | ||
| public <T> Message<T> of(T payload, Metadata metadata) { |
There was a problem hiding this comment.
Moving these methods here is not backward compatible, not sure how relevant that is.
There was a problem hiding this comment.
I think it's probably fine since the feature is very recent.
There was a problem hiding this comment.
Ok, just don't forget to update the webinar (if necessary) :)
There was a problem hiding this comment.
luckily I did not use the publisher side :D
efgpinto
approved these changes
Aug 28, 2023
| */ | ||
| static <T> Message<T> of(T payload, Metadata metadata) { | ||
| public <T> Message<T> of(T payload, Metadata metadata) { |
There was a problem hiding this comment.
I think it's probably fine since the feature is very recent.
aludwiko
deleted the
1774-eventingtestkit-should-respect-typename-annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1774