Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eventing testkit - supporting multiple subscription to the same … #1778

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: eventing testkit - supporting multiple subscription to the same … #1778

merged 1 commit into from
Aug 28, 2023

Conversation

aludwiko
Copy link
Contributor

References #1773

Base automatically changed from 1774-eventingtestkit-should-respect-typename-annotation to main August 28, 2023 09:44
@aludwiko aludwiko force-pushed the 1773-eventingtestkit-doesnt-work-with-multiple-subscriptions-to-the-same-topic branch from a483ac5 to 4754a01 Compare August 28, 2023 09:49
@aludwiko aludwiko linked an issue Aug 28, 2023 that may be closed by this pull request
EventingTestKit doesn't work with multiple subscriptions to the same topic #1773
Closed
@aludwiko aludwiko requested a review from efgpinto August 28, 2023 09:50
efgpinto
efgpinto approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@aludwiko aludwiko merged commit dfe7e7e into main Aug 28, 2023
67 checks passed
@aludwiko aludwiko deleted the 1773-eventingtestkit-doesnt-work-with-multiple-subscriptions-to-the-same-topic branch August 28, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efgpinto efgpinto efgpinto approved these changes

Assignees
No one assigned
Labels
java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventingTestKit doesn't work with multiple subscriptions to the same topic
2 participants
@aludwiko @efgpinto