Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate compound ids order in the path #1839

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: validate compound ids order in the path #1839

merged 1 commit into from
Nov 3, 2023

Conversation

aludwiko
Copy link
Contributor

@aludwiko aludwiko commented Nov 3, 2023 •
edited
Loading

References #1838

@aludwiko aludwiko linked an issue Nov 3, 2023 that may be closed by this pull request
Validate the order of compound id keys in the endpoints. #1838
Closed
@github-actions github-actions bot added java-sdk kalix-runtime Runtime and SDKs sub-team labels Nov 3, 2023
@aludwiko aludwiko marked this pull request as ready for review November 3, 2023 12:29
johanandren
johanandren approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aludwiko aludwiko merged commit 81265fd into main Nov 3, 2023
67 checks passed
@aludwiko aludwiko deleted the 1838-validate-the-order-of-compound-id-keys-in-the-endpoints branch November 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
java-sdk kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate the order of compound id keys in the endpoints.
2 participants
@aludwiko @johanandren