Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user friendly name of the kalix proxy docker container #1847

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: user friendly name of the kalix proxy docker container #1847

merged 1 commit into from
Nov 8, 2023

Conversation

aludwiko
Copy link
Contributor

@aludwiko aludwiko commented Nov 7, 2023

References #1844

@aludwiko aludwiko linked an issue Nov 7, 2023 that may be closed by this pull request
Set a more user friendly name for the kalix-runtime in docker-compose files #1844
Closed
@efgpinto
Copy link
Member

efgpinto commented Nov 7, 2023 •
edited
Loading

Should we maybe append a -runtime or something? otherwise, when we package the userfunction to run alongside (e.g. on a docker compose) which name would it have?

@octonato
Copy link
Member

octonato commented Nov 8, 2023

@efgpinto, we need to experiment with this. But I think it's ok to have it as such. The image name of the service won't be the same as the name chosen here. It will be similar though.

The image will be like: user-selected-docker-register/artifactId while the kalix-runtime when running locally will be artifactId.

What we want is to have a name that emulates the name of the service in prod. At least to start with. User's could eventually change that name and not change it in all places. But that's not in our control anymore.

octonato
octonato approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the Documentation Improvements or additions to the documentation label Nov 8, 2023
@aludwiko aludwiko force-pushed the 1844-set-a-more-user-friendly-name-for-the-kalix-runtime-in-docker-compose-files branch from b06bddd to c40b615 Compare November 8, 2023 08:18
@github-actions github-actions bot removed the Documentation Improvements or additions to the documentation label Nov 8, 2023
@aludwiko aludwiko merged commit f3f6216 into main Nov 8, 2023
130 of 131 checks passed
@aludwiko aludwiko deleted the 1844-set-a-more-user-friendly-name-for-the-kalix-runtime-in-docker-compose-files branch November 8, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set a more user friendly name for the kalix-runtime in docker-compose files
3 participants
@aludwiko @efgpinto @octonato