Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps: current Maven plugins #1866

Merged
merged 7 commits into from
Nov 20, 2023
Merged

bumps: current Maven plugins #1866

merged 7 commits into from
Nov 20, 2023

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 17, 2023

  • Spring Boot 3.1.5 (was 3.1.4)
  • Maven Surefire/Failsafe 3.2.2 (was 2.22.2) deferred
  • Maven Deploy 3.1.1 (was 3.0.0-M1)
  • Fabric8 Plugin 0.43.4 (was 0.39.1)
  • OS Maven plugin 1.7.1 (was 1.7.0)

Removes the Maven Compiler Plugin and the Surefire/Failsafe plugins in the Spring poms as those inherit it from the Spring Boot pom.

Supersedes

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team labels Nov 17, 2023
@ennru
Copy link
Member Author

ennru commented Nov 17, 2023

Looks like Surefire is unhappy with some bump.

@ennru
Copy link
Member Author

ennru commented Nov 20, 2023

Only protobuf samples are failing as the main class isn't there.

  • java-protobuf-customer-registry-quickstart

  • java-protobuf-customer-registry-kafka-quickstart

  • java-protobuf-customer-registry-views-quickstart

  • java-protobuf-eventsourced-counter

  • java-protobuf-eventsourced-customer-registry

  • java-protobuf-eventsourced-customer-registry-subscriber

  • java-protobuf-eventsourced-shopping-cart

  • java-protobuf-replicatedentity-shopping-cart

  • java-protobuf-replicatedentity-examples

  • java-protobuf-shopping-cart-quickstart

  • java-protobuf-valueentity-counter

  • java-protobuf-view-store

@ennru
Copy link
Member Author

ennru commented Nov 20, 2023

The bump of Maven Surefire/Failsafe needs more investigation. They changed how they do forking and classpath handling.

"...changed between Surefire 2.3 and Surefire 2.4, which was a pretty significant change." see Class Loading and Forking in Maven Surefire

The jump to 3.x contained more changes needing investigation, see history

@ennru ennru merged commit fda0ab6 into main Nov 20, 2023
65 of 67 checks passed
@ennru ennru deleted the ennru-maven-bumps-2 branch November 20, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants