Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Runtime" as Docker image and service names; Runtime 1.1.27 #1895

Merged
merged 14 commits into from
Dec 12, 2023

Conversation

ennru
Copy link
Member

@ennru ennru commented Dec 5, 2023

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf labels Dec 5, 2023
#!/usr/bin/env bash

# USAGE:
# > RUNTIME_VERSION=1.0.31 ./updateRuntimeVersions.sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this is called from during the Runtime release process. The file rename must be reflected there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only used by us (by me at least).

Copy link
Member

@efgpinto efgpinto Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used here when opening a Auto PR upon runtime release.

@ennru ennru marked this pull request as draft December 5, 2023 13:54
@ennru
Copy link
Member Author

ennru commented Dec 5, 2023

@@ -88,7 +88,7 @@ public KalixProxyContainer(
if ("false".equals(System.getenv("VERSION_CHECK_ON_STARTUP"))) {
withEnv("VERSION_CHECK_ON_STARTUP", "false");
}
waitingFor(Wait.forLogMessage(".*gRPC proxy started.*", 1));
waitingFor(Wait.forLogMessage(".*(gRPC proxy|Kalix Runtime) started.*", 1));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. I completely forgot about this.

Can good trick to match on both. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We put the old log output back, so that bumping the Runtime works even if the Testkit isn't upgraded.

@ennru ennru marked this pull request as ready for review December 6, 2023 14:17
@ennru ennru changed the title Use "Runtime" as Docker image and service names Use "Runtime" as Docker image and service names; Runtime 1.1.26 Dec 8, 2023
@ennru ennru changed the title Use "Runtime" as Docker image and service names; Runtime 1.1.26 Use "Runtime" as Docker image and service names; Runtime 1.1.27 Dec 11, 2023
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.27 reached prod, I will merge this one to unlock some other PRs.

build.sbt Outdated Show resolved Hide resolved
USER_FUNCTION_PORT: ${USER_FUNCTION_PORT:-8080}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.1.26, we can call this USER_SERVICE_HOST and USER_SERVICE_PORT.

But before changing it, we need to adapt the mvn and sbt plugin. The plugins read this env vars from the docker-compose as well.

@octonato octonato merged commit eb0ba12 into main Dec 12, 2023
68 checks passed
@octonato octonato deleted the ennru-runtime-image branch December 12, 2023 20:36
aklikic pushed a commit to aklikic/kalix-jvm-sdk that referenced this pull request Jan 15, 2024
…tbend#1895)

* Use image name kalix-runtime (was kalix-proxy)

* Adapt Runtime version updating helpers

* Rename Docker compose services

* Kalix Runtime 1.1.25

* More safe renames

* Missed a few versions

* Service name in DockerComposeUtilsSpec

* Found even more, sigh

* Make TestContainers wait for the new message

* Use Runtime 1.1.26

* some more proxy > runtime renaming

* Kalix Runtime 1.1.27

* delegate from old update script name

* typo

---------

Co-authored-by: Renato Cavalcanti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants