-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "Runtime" as Docker image and service names; Runtime 1.1.27 #1895
Conversation
#!/usr/bin/env bash | ||
|
||
# USAGE: | ||
# > RUNTIME_VERSION=1.0.31 ./updateRuntimeVersions.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this is called from during the Runtime release process. The file rename must be reflected there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only used by us (by me at least).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used here when opening a Auto PR upon runtime release.
Now includes |
devtools/src/test/scala/kalix/devtools/impl/DockerComposeUtilsSpec.scala
Outdated
Show resolved
Hide resolved
@@ -88,7 +88,7 @@ public KalixProxyContainer( | |||
if ("false".equals(System.getenv("VERSION_CHECK_ON_STARTUP"))) { | |||
withEnv("VERSION_CHECK_ON_STARTUP", "false"); | |||
} | |||
waitingFor(Wait.forLogMessage(".*gRPC proxy started.*", 1)); | |||
waitingFor(Wait.forLogMessage(".*(gRPC proxy|Kalix Runtime) started.*", 1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch. I completely forgot about this.
Can good trick to match on both. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We put the old log output back, so that bumping the Runtime works even if the Testkit isn't upgraded.
52bfc81
to
77a6aad
Compare
0e5d223
to
640648a
Compare
758e6b6
to
df3d443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.1.27 reached prod, I will merge this one to unlock some other PRs.
USER_FUNCTION_PORT: ${USER_FUNCTION_PORT:-8080} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 1.1.26, we can call this USER_SERVICE_HOST
and USER_SERVICE_PORT
.
But before changing it, we need to adapt the mvn and sbt plugin. The plugins read this env vars from the docker-compose as well.
…tbend#1895) * Use image name kalix-runtime (was kalix-proxy) * Adapt Runtime version updating helpers * Rename Docker compose services * Kalix Runtime 1.1.25 * More safe renames * Missed a few versions * Service name in DockerComposeUtilsSpec * Found even more, sigh * Make TestContainers wait for the new message * Use Runtime 1.1.26 * some more proxy > runtime renaming * Kalix Runtime 1.1.27 * delegate from old update script name * typo --------- Co-authored-by: Renato Cavalcanti <[email protected]>
The image has been published with a name alias.
References