Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java spring cinema booking quickstart #1916

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Java spring cinema booking quickstart #1916

wants to merge 51 commits into from

Conversation

aklikic
Copy link

@aklikic aklikic commented Dec 13, 2023

No description provided.

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk kalix-runtime Runtime and SDKs sub-team labels Dec 13, 2023
octonato
octonato reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first pass. Left some comments here and there. We need to align with the decisions we took about how to organise the code.

Also, since this sample was originally build for a blog post and not for a quickstart, we need reconsider the amount of code we are producing here.

I would try to bring it to a minimal. For example, having three different methods abstracting away a call to UUID.random is not adding value. We need to be a little more pragmatic and produce only what is needed.

samples/java-spring-cinema-booking-choreography/images/cinema-show-usecase.png Outdated Show resolved Hide resolved
...pring-cinema-booking-choreography/src/main/java/com/example/cinema/model/CinemaApiModel.java Outdated Show resolved Hide resolved
...pring-cinema-booking-choreography/src/main/java/com/example/cinema/model/CinemaApiModel.java Outdated Show resolved Hide resolved
...pring-cinema-booking-choreography/src/main/java/com/example/cinema/model/CinemaApiModel.java Outdated Show resolved Hide resolved
...pring-cinema-booking-choreography/src/main/java/com/example/cinema/model/CinemaApiModel.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...va-spring-cinema-booking-choreography/src/test/java/com/example/cinema/DomainGenerators.java Outdated Show resolved Hide resolved
...es/java-spring-cinema-booking-choreography/src/test/java/com/example/cinema/ShowBuilder.java Outdated Show resolved Hide resolved
octonato
octonato reviewed Dec 19, 2023
View reviewed changes
docs/Makefile Outdated
@@ -91,6 +91,7 @@ bundles:
bin/bundle.sh --zip "${java_managed_attachments}/java-spring-customer-registry-quickstart.zip" ../samples/java-spring-customer-registry-quickstart
bin/bundle.sh --zip "${java_managed_attachments}/java-spring-customer-registry-views-quickstart.zip" ../samples/java-spring-customer-registry-views-quickstart
bin/bundle.sh --zip "${java_managed_attachments}/java-spring-shopping-cart-quickstart.zip" ../samples/java-spring-shopping-cart-quickstart
bin/bundle.sh --zip "${java_managed_attachments}/java-spring-cinema-booking-choreography.zip" ../samples/java-spring-cinema-booking-choreography
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suffix it with -quickstart

aludwiko
aludwiko reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@aludwiko aludwiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments for starters

...-booking-choreography/src/it/java/com/example/cinema/ShowSeatReservationIntegrationTest.java Outdated Show resolved Hide resolved
...ng-choreography/src/it/java/com/example/cinema/ShowsByAvailableSeatsViewIntegrationTest.java Outdated Show resolved Hide resolved
...pring-cinema-booking-choreography/src/main/java/com/example/cinema/model/CinemaApiModel.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated
Map<String, FinishedReservation> finishedReservations, int availableSeats) {

public static Show create(ShowEvent.ShowCreated showCreated) {
List<Tuple2<Integer, Seat>> seats = showCreated.seats().stream().map(seat -> new Tuple2<>(seat.number(), seat)).toList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but maybe they added sth in the mean time.

...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
...les/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/model/Show.java Outdated Show resolved Hide resolved
aklikic and others added 30 commits January 12, 2024 11:19
@aklikic
- command and event handler methods renamed from handleReservation an…
f980576 
…d applyReserved to onCommand and onEvent
@aklikic
- removed random uuid abstraction methods
ef74de3
@aklikic
- random Show title name change
7989027
@octonato @ennru @aklikic
docs: choreography saga quickstart (lightbend#1884)
ff11f8d 
* docs: choreography saga quickstart

* Minor text updates

* Update samples/java-spring-choreography-saga-quickstart/pom.xml

Co-authored-by: Enno Runne <[email protected]>

---------

Co-authored-by: Enno Runne <[email protected]>
@aklikic
- WebClient replaced with ComponentClient
1b80e6a
@aklikic
- code format
3646d2e
@franciscolopezsancho @aklikic
feat: reading the collector endpoint from the ProxyInfo (lightbend#1893)
3cbe872 
* feat: reading the collector endpoint from the ProxyInfo
@aludwiko @aklikic
chore: bump scala version 2.13.10 -> 2.13.12 (lightbend#1902)
7e43b60
@octonato @ennru @aklikic
docs: choreography saga quickstart (lightbend#1884)
7e724b0 
* docs: choreography saga quickstart

* Minor text updates

* Update samples/java-spring-choreography-saga-quickstart/pom.xml

Co-authored-by: Enno Runne <[email protected]>

---------

Co-authored-by: Enno Runne <[email protected]>
@octonato @aklikic
chore: fix typo (lightbend#1906)
8b0fc19
@aludwiko @aklikic
chore: bump scala tooling version 2.12.15 -> 2.12.18 (lightbend#1908)
124e256 
* chore: bump scala tooling version 2.12.15 -> 2.12.18

* missing bump
@ennru @octonato @aklikic
Use "Runtime" as Docker image and service names; Runtime 1.1.27 (ligh…
e8234a9 
…tbend#1895)

* Use image name kalix-runtime (was kalix-proxy)

* Adapt Runtime version updating helpers

* Rename Docker compose services

* Kalix Runtime 1.1.25

* More safe renames

* Missed a few versions

* Service name in DockerComposeUtilsSpec

* Found even more, sigh

* Make TestContainers wait for the new message

* Use Runtime 1.1.26

* some more proxy > runtime renaming

* Kalix Runtime 1.1.27

* delegate from old update script name

* typo

---------

Co-authored-by: Renato Cavalcanti <[email protected]>
@aludwiko @aklikic
chore: improve error message for JSON deserialization (lightbend#1911)
b53fc81
@efgpinto @octonato @aklikic
docs: actions as service life-cycle hooks (lightbend#1909)
f3da4a9 
* Apply suggestions from code review

Co-authored-by: Renato Cavalcanti <[email protected]>

---------

Co-authored-by: Renato Cavalcanti <[email protected]>
@kalix-bot @aklikic
chore: bump SDK versions to 1.3.6 (lightbend#1915)
732292c
@efgpinto @aklikic
fix: maven archetype kcr vars (lightbend#1917)
16e01fe
@aludwiko @aklikic
fix: Hello world action exposed to the internet in code first archety…
ba3d16c 
…pes (lightbend#1920)
@aludwiko @aklikic
docs: documenting persistent dev mode (lightbend#1918)
a5e374b
@kalix-bot @aklikic
chore: bump SDK versions to 1.3.7 (lightbend#1922)
78e6738
@aklikic
update cinema show use cases with images that we do not need copyrigh…
51857a4 
…t for
@aklikic
adopting convention to add commands and events as inner records of th…
fdbe67e 
…e domain class
@aklikic
moving Response Record to common package
7c35644
@aklikic
- command and event handler methods renamed from handleReservation an…
599fd0e 
…d applyReserved to onCommand and onEvent
@aklikic
- removed random uuid abstraction methods
67a87e3
@aklikic
- random Show title name change
58c0bf2
@octonato @ennru @aklikic
docs: choreography saga quickstart (lightbend#1884)
2c7c250 
* docs: choreography saga quickstart

* Minor text updates

* Update samples/java-spring-choreography-saga-quickstart/pom.xml

Co-authored-by: Enno Runne <[email protected]>

---------

Co-authored-by: Enno Runne <[email protected]>
@aklikic
- WebClient replaced with ComponentClient
707f398
@aklikic
- code format
ec519d9
@aklikic
- removing unused command
614675b
@aklikic
Merge remote-tracking branch 'origin/java-spring-cinema-booking' into…
4753b22 
… java-spring-cinema-booking

# Conflicts:
#	docs/Makefile
#	samples/java-spring-cinema-booking-choreography/src/main/java/com/example/cinema/Show.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beritou beritou beritou left review comments

@aludwiko aludwiko aludwiko left review comments

@octonato octonato octonato left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation Improvements or additions to the documentation kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aklikic @octonato @aludwiko @beritou @ennru @franciscolopezsancho @efgpinto @kalix-bot